Fingerprint sensors #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
force-pushed
the
fingerprint-sensors
branch
11 times, most recently
from
fe4708a to
39c2a1e
Compare
|
@r-vdp does this work for you? |
Mic92
commented
Nov 4, 2024
Mic92
force-pushed
the
fingerprint-sensors
branch
4 times, most recently
from
1e60080 to
993f006
Compare
Mic92
force-pushed
the
fingerprint-sensors
branch
from
993f006 to
3828485
Compare
|
I tested this now on two different laptops. I thing this is good to go for the first iteration. |
brianmcgee
approved these changes
Nov 5, 2024
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d0e205e |
|
@mergify refresh |
✅ Pull request refreshed |
|
@Mic92 sorry I was busy yesterday, but it detects the fingerprint sensor on my framework! |
|
@r-vdp we have too many frameworks. Not enough diversity. |
Are you saying I need to expense some hardware? 🤔 |
|
@brianmcgee you probably have to travel to thailand some time. |
brianmcgee
added a commit
to nix-community/nixos-facter
that referenced
this pull request
Nov 5, 2024
Helps address issues brought up in nix-community/nixos-facter-modules#58 by introducing an additional hex field in the Id type. Eventually, we can make this a breaking change by removing the value field and incrementing the report version. This is a chance to test out how we can introduce breaking changes, whilst allowing module authors time to update. Closes #141
brianmcgee
added a commit
to nix-community/nixos-facter
that referenced
this pull request
Nov 6, 2024
Helps address issues brought up in nix-community/nixos-facter-modules#58 by introducing an additional hex field in the Id type. Eventually, we can make this a breaking change by removing the value field and incrementing the report version. This is a chance to test out how we can introduce breaking changes, whilst allowing module authors time to update. Closes #141 Signed-off-by: Brian McGee <[email protected]>
brianmcgee
added a commit
to nix-community/nixos-facter
that referenced
this pull request
Nov 6, 2024
Helps address issues brought up in nix-community/nixos-facter-modules#58 by introducing an additional hex field in the Id type. Eventually, we can make this a breaking change by removing the value field and incrementing the report version. This is a chance to test out how we can introduce breaking changes, whilst allowing module authors time to update. Closes #141 Signed-off-by: Brian McGee <[email protected]>
brianmcgee
added a commit
to nix-community/nixos-facter
that referenced
this pull request
Nov 7, 2024
Helps address issues brought up in nix-community/nixos-facter-modules#58 by introducing an additional hex field in the Id type. Eventually, we can make this a breaking change by removing the value field and incrementing the report version. This is a chance to test out how we can introduce breaking changes, whilst allowing module authors time to update. Closes #141 Signed-off-by: Brian McGee <[email protected]>
mergify bot
pushed a commit
to nix-community/nixos-facter
that referenced
this pull request
Nov 7, 2024
Helps address issues brought up in nix-community/nixos-facter-modules#58 by introducing an additional hex field in the Id type. Eventually, we can make this a breaking change by removing the value field and incrementing the report version. This is a chance to test out how we can introduce breaking changes, whilst allowing module authors time to update. Closes #141 Signed-off-by: Brian McGee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.